-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5915] Add support for the new documentation theme #6563
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6563 +/- ##
==========================================
- Coverage 83.53% 83.29% -0.24%
==========================================
Files 645 645
Lines 37286 37291 +5
==========================================
- Hits 31147 31063 -84
- Misses 6139 6228 +89
Continue to review full report at Codecov.
|
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
* Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Unnecessary space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the licenses look like in the other files. This license was added automatically and I had no influence on its content.
https://github.com/apache/airflow/blob/master/airflow/www/static/js/base.js
https://github.com/apache/airflow/blob/master/airflow/www/static/js/connection_form.js
https://github.com/apache/airflow/blob/master/airflow/www/static/js/datetime-utils.js
https://github.com/apache/airflow/blob/master/airflow/www/static/js/gantt-chart-d3v2.js
https://github.com/apache/airflow/blob/master/airflow/www/static/js/graph.js
Definition of comment style is available here:
airflow/.pre-commit-config.yaml
Line 66 in 2b1de0b
- "/**| *| */" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It's how it should be for consistency :).
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
* Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It's how it should be for consistency :).
What license is bootstrap released under? Is it right to put an ASF header on it? |
Bootstrap is under MIT license. We are modifying its source code, so we need to have a header. If we imported correctly, i.e. using SCSS, and the code as an import to external libraries. We would not have this code in this form. Now we have a de facto fork of this library, so we need to have header. |
(cherry picked from commit 63fcc73)
(cherry picked from commit 63fcc73)
(cherry picked from commit 63fcc73)
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation