-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6014] - handle pods which are preempted and deleted by kuber… #6606
Conversation
…netes but not restarted
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@dimberman would it be possible to take a look at this? |
cc @dimberman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are running a fork of Airflow with a similar fix, really hoping this gets merged on upstream!
LGTM. I put in a fix for a new namespace awareness and if tests pass I will merge. Apologies for the delay this one fell through the cracks :/ |
Codecov Report
@@ Coverage Diff @@
## master #6606 +/- ##
==========================================
- Coverage 86.96% 86.71% -0.26%
==========================================
Files 915 915
Lines 44188 44201 +13
==========================================
- Hits 38429 38328 -101
- Misses 5759 5873 +114
Continue to review full report at Codecov.
|
Awesome work, congrats on your first merged pull request! |
…netes but not restarted
Make sure you have checked all steps below.
Jira
Description
This PR addresses the issue of when a pod is Preempted during the creation phase and due to pods having the following in the spec
restartPolicy: Never
The pod is never restarted and ends up as a queued task within Airflow until the scheduler is restarted.Tests
Unsure if it is possible to simulate this scenario.
Commits
Documentation