Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5947] Make the json backend pluggable for DAG Serialization #6630

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 21, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Allow users the option to choose the JSON library of their choice for DAG Serialization.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from ashb November 21, 2019 23:23
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #6630 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6630      +/-   ##
==========================================
- Coverage   83.79%   83.48%   -0.31%     
==========================================
  Files         669      669              
  Lines       37548    37552       +4     
==========================================
- Hits        31464    31351     -113     
- Misses       6084     6201     +117
Impacted Files Coverage Δ
airflow/serialization/serialized_dag.py 96% <ø> (ø) ⬆️
airflow/settings.py 88.96% <100%> (+0.15%) ⬆️
airflow/serialization/serialization.py 82.57% <100%> (ø) ⬆️
airflow/models/serialized_dag.py 85.71% <100%> (+0.34%) ⬆️
airflow/serialization/json_schema.py 81.81% <100%> (ø) ⬆️
airflow/operators/mysql_operator.py 100% <0%> (ø) ⬆️
airflow/operators/mysql_to_hive.py 100% <0%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da08666...5dda74e. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@kaxil kaxil merged commit b401409 into apache:master Nov 22, 2019
@kaxil kaxil deleted the AIRFLOW-5947 branch November 22, 2019 11:46
kaxil added a commit that referenced this pull request Dec 18, 2019
ashb pushed a commit that referenced this pull request Dec 18, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
kaxil added a commit that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants