[AIRFLOW-6045] Error on failed execution of compile_assets #6640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/AIRFLOW-6045
Make sure you have checked all steps below.
Jira
Description
Currently, if someone runs
python setup.py compile_assets sdist
and if they don't have npm install or if for some reason the script called by compile_assets function fail, the function does nothing as it usessubprocess.call
. We should usesubprocess.check_call
to fix itTests
Commits
Documentation