Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6045] Error on failed execution of compile_assets #6640

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 22, 2019

https://issues.apache.org/jira/browse/AIRFLOW-6045

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Currently, if someone runs python setup.py compile_assets sdist and if they don't have npm install or if for some reason the script called by compile_assets function fail, the function does nothing as it uses subprocess.call. We should use subprocess.check_call to fix it

Tests

  • [] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested review from ashb and dimberman November 22, 2019 15:31
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b0bdd37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6640   +/-   ##
=========================================
  Coverage          ?   83.47%           
=========================================
  Files             ?      672           
  Lines             ?    37567           
  Branches          ?        0           
=========================================
  Hits              ?    31358           
  Misses            ?     6209           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bdd37...32e007b. Read the comment docs.

@kaxil kaxil merged commit fa626f0 into apache:master Nov 22, 2019
@kaxil kaxil deleted the error-on-fail-assets branch November 22, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants