Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Fix incorrect docstring parameter #6649

Merged
merged 2 commits into from
Nov 23, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 23, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    old_state instead of old_states

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from XD-DENG November 23, 2019 14:24
@@ -751,7 +751,7 @@ def _change_state_for_tis_without_dagrun(self,
changed manually.

:param old_states: examine TaskInstances in this state
:type old_state: list[airflow.utils.state.State]
:type old_states: list[airflow.utils.state.State]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kaxil , seems there is the same error in line 758. Do you mind fixing it together?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@XD-DENG XD-DENG merged commit 3ac5270 into apache:master Nov 23, 2019
@XD-DENG
Copy link
Member

XD-DENG commented Nov 23, 2019

Have merged given I don't see any chance that it bringing in CI failure ;-)

@kaxil kaxil deleted the fix-docstring-param branch November 29, 2019 21:19
kaxil added a commit that referenced this pull request Dec 14, 2019
kaxil added a commit that referenced this pull request Dec 14, 2019
kaxil added a commit that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants