-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6054] Add a command that starts the database consoles #6653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6653 +/- ##
==========================================
- Coverage 83.82% 82.97% -0.85%
==========================================
Files 672 672
Lines 37560 37584 +24
==========================================
- Hits 31483 31186 -297
- Misses 6077 6398 +321
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea!
nice addition. lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mik-laj - looks fantastic.
One small thing -> I think it's worth adding a mention in LOCAL_VIRTUALENV.rst - adding a separate "Connecting to database" chapter in "Debugging and Running Tests". We have a change in progress to separate out a TESTING.rst in #6585 with @efedotova so we will rebase and incorporate content of this chapter in this change after you merge it.
@potiuk Done. I added a mention in LOCAL_VIRTUALENV.rst. |
Fantastic! |
(cherry picked from commit ae96f27)
(cherry picked from commit ae96f27)
@potiuk This will be a very nice improvement for development environment including Breeze.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation