Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6054] Add a command that starts the database consoles #6653

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Nov 24, 2019

@potiuk This will be a very nice improvement for development environment including Breeze.


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6054
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #6653 into master will decrease coverage by 0.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6653      +/-   ##
==========================================
- Coverage   83.82%   82.97%   -0.85%     
==========================================
  Files         672      672              
  Lines       37560    37584      +24     
==========================================
- Hits        31483    31186     -297     
- Misses       6077     6398     +321
Impacted Files Coverage Δ
airflow/bin/cli.py 92.64% <ø> (ø) ⬆️
airflow/cli/commands/db_command.py 97.43% <100%> (+17.43%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/executors/celery_executor.py 41.04% <0%> (-35.08%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4be19...28e9d1f. Read the comment docs.

Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea!

@msumit
Copy link
Contributor

msumit commented Nov 25, 2019

nice addition. lgtm.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mik-laj - looks fantastic.

One small thing -> I think it's worth adding a mention in LOCAL_VIRTUALENV.rst - adding a separate "Connecting to database" chapter in "Debugging and Running Tests". We have a change in progress to separate out a TESTING.rst in #6585 with @efedotova so we will rebase and incorporate content of this chapter in this change after you merge it.

@mik-laj
Copy link
Member Author

mik-laj commented Nov 25, 2019

@potiuk Done. I added a mention in LOCAL_VIRTUALENV.rst.

@potiuk
Copy link
Member

potiuk commented Nov 25, 2019

Fantastic!

@mik-laj mik-laj merged commit ae96f27 into apache:master Nov 25, 2019
potiuk pushed a commit that referenced this pull request Dec 9, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants