Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6083] Add custom configuration to AWS lambda client #6678

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

Daumis102
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6083
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    My PR adds ability to provide Lambda client with custom configuration.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: It does not need testing as the functionality that was already implemented in function get_client_type was defaulting config param to None, which I also do in case no config is provided to AwsLambdaHook constructor. If config is provided, then the only thing I do is pass it to the client creation function, which already has everything else implemented.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

…client.

There was no way to pass custom configuration from AwsLambdaHook to lambda client. This was an issue when for example default lambda timeout was too short.
@mik-laj mik-laj changed the title [AIRFLOW-6083] Adding custom configuration to lambda client [AIRFLOW-6083] Add custom configuration to AWS lambda client Nov 27, 2019
@mik-laj mik-laj added the provider:amazon-aws AWS/Amazon - related issues label Nov 27, 2019
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #6678 into master will decrease coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6678      +/-   ##
==========================================
- Coverage   83.86%   83.53%   -0.33%     
==========================================
  Files         668      668              
  Lines       37537    37538       +1     
==========================================
- Hits        31479    31356     -123     
- Misses       6058     6182     +124
Impacted Files Coverage Δ
...flow/providers/amazon/aws/hooks/lambda_function.py 100% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/jobs/backfill_job.py 89.9% <0%> (-1.53%) ⬇️
airflow/utils/dag_processing.py 58.15% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2d0be...e92dafa. Read the comment docs.

@OmerJog
Copy link
Contributor

OmerJog commented Dec 16, 2019

Ready to merge?

@ashb ashb merged commit c4c635d into apache:master Dec 17, 2019
kaxil pushed a commit that referenced this pull request Dec 17, 2019
…client. (#6678)

There was no way to pass custom configuration from AwsLambdaHook to
lambda client. This was an issue when for example default lambda timeout
was too short.

(cherry picked from commit c4c635d)
kaxil pushed a commit that referenced this pull request Dec 18, 2019
…client. (#6678)

There was no way to pass custom configuration from AwsLambdaHook to
lambda client. This was an issue when for example default lambda timeout
was too short.

(cherry picked from commit c4c635d)
ashb pushed a commit that referenced this pull request Dec 19, 2019
…client. (#6678)

There was no way to pass custom configuration from AwsLambdaHook to
lambda client. This was an issue when for example default lambda timeout
was too short.

(cherry picked from commit c4c635d)
KKcorps pushed a commit to KKcorps/airflow that referenced this pull request Dec 21, 2019
…client. (apache#6678)

There was no way to pass custom configuration from AwsLambdaHook to lambda client. This was an issue when for example default lambda timeout was too short.
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…client. (apache#6678)

There was no way to pass custom configuration from AwsLambdaHook to lambda client. This was an issue when for example default lambda timeout was too short.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants