Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3656] Show doc link for the current installed version #6690

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 29, 2019

Make sure you have checked all steps below.

Jira

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    added

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested review from ashb and potiuk November 29, 2019 13:48
@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #6690 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6690      +/-   ##
==========================================
- Coverage   83.83%   83.82%   -0.02%     
==========================================
  Files         668      668              
  Lines       37543    37546       +3     
==========================================
- Hits        31476    31474       -2     
- Misses       6067     6072       +5
Impacted Files Coverage Δ
airflow/www/app.py 95.76% <75%> (-0.76%) ⬇️
airflow/jobs/local_task_job.py 86.25% <0%> (-3.75%) ⬇️
airflow/utils/dag_processing.py 57.99% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e91b...d522880. Read the comment docs.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL we didn't had that? I haven't noticed that the whole time - probably because I am always using the latest version :D

QoL change :)

@kaxil kaxil merged commit 15e30dd into apache:master Nov 29, 2019
@kaxil kaxil deleted the airflow-3656 branch November 29, 2019 18:54
kaxil added a commit that referenced this pull request Dec 17, 2019
kaxil added a commit that referenced this pull request Dec 17, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants