-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIRFLOW-6132 - Allow to pass in tags #6694
Conversation
* allow to pass in tags
Codecov Report
@@ Coverage Diff @@
## master #6694 +/- ##
==========================================
- Coverage 83.83% 83.51% -0.32%
==========================================
Files 668 668
Lines 37547 37557 +10
==========================================
- Hits 31477 31367 -110
- Misses 6070 6190 +120
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it used somewhere? It does not see, to be changed in execute (). Also some test accompanying this change would be great.
* add test
@potiuk This change I think it does not impact anything else as ContainerGroup object already has the tag field. I just exposed it to the Operator. I added a test now. I hope travis re-builds it. |
* fix pep8
@potiuk can we merge ? |
Thanks @jomach ! |
* AIRFLOW-6132 * allow to pass in tags (cherry picked from commit 0a0d097)
* AIRFLOW-6132 * allow to pass in tags (cherry picked from commit 0a0d097)
* AIRFLOW-6132 * allow to pass in tags (cherry picked from commit 0a0d097)
* AIRFLOW-6132 * allow to pass in tags
Jira
Description
Small change to allow pass in tags for the azure cloud
Documentation
added python docs