Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRFLOW-6132 - Allow to pass in tags #6694

Merged
merged 3 commits into from
Dec 3, 2019
Merged

AIRFLOW-6132 - Allow to pass in tags #6694

merged 3 commits into from
Dec 3, 2019

Conversation

jomach
Copy link
Contributor

@jomach jomach commented Nov 30, 2019

Jira

Description

Small change to allow pass in tags for the azure cloud

Documentation

added python docs

* allow to pass in tags
@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #6694 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6694      +/-   ##
==========================================
- Coverage   83.83%   83.51%   -0.32%     
==========================================
  Files         668      668              
  Lines       37547    37557      +10     
==========================================
- Hits        31477    31367     -110     
- Misses       6070     6190     +120
Impacted Files Coverage Δ
...ib/operators/azure_container_instances_operator.py 78.14% <100%> (+0.14%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
...irflow/providers/apache/cassandra/sensors/table.py 100% <0%> (ø) ⬆️
...rflow/providers/apache/cassandra/sensors/record.py 100% <0%> (ø) ⬆️
airflow/operators/dagrun_operator.py 96.15% <0%> (+0.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815c96e...edb09d1. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used somewhere? It does not see, to be changed in execute (). Also some test accompanying this change would be great.

* add test
@jomach
Copy link
Contributor Author

jomach commented Nov 30, 2019

@potiuk This change I think it does not impact anything else as ContainerGroup object already has the tag field. I just exposed it to the Operator. I added a test now. I hope travis re-builds it.

* fix pep8
@jomach
Copy link
Contributor Author

jomach commented Dec 2, 2019

@potiuk can we merge ?

@potiuk potiuk merged commit 0a0d097 into apache:master Dec 3, 2019
@potiuk
Copy link
Member

potiuk commented Dec 3, 2019

Thanks @jomach !

kaxil pushed a commit that referenced this pull request Dec 19, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
kaxil pushed a commit that referenced this pull request Dec 19, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants