Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6168] allows proxyfix to be configurable #6723

Merged
merged 1 commit into from
Dec 10, 2019
Merged

[AIRFLOW-6168] allows proxyfix to be configurable #6723

merged 1 commit into from
Dec 10, 2019

Conversation

timkpaine
Copy link
Contributor

@timkpaine timkpaine commented Dec 4, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Super straightforward, basically allows the kwargs to ProxyFix to be configured individually in the configuration file.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Added tests for the www/app.py for this feature

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Documentation updated

@timkpaine timkpaine changed the title AIRFLOW-6168 allows proxyfix to be configurable [AIRFLOW-6168] allows proxyfix to be configurable Dec 4, 2019
tests/www/test_app.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #6723 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6723     +/-   ##
=========================================
- Coverage   84.54%   83.95%   -0.6%     
=========================================
  Files         672      672             
  Lines       38081    38081             
=========================================
- Hits        32197    31971    -226     
- Misses       5884     6110    +226
Impacted Files Coverage Δ
airflow/www/app.py 97.45% <ø> (+0.84%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/executors/celery_executor.py 49.66% <0%> (-38.93%) ⬇️
airflow/utils/sqlalchemy.py 84.74% <0%> (-11.87%) ⬇️
airflow/executors/executor_loader.py 58.69% <0%> (-4.35%) ⬇️
airflow/hooks/dbapi_hook.py 88.13% <0%> (-3.39%) ⬇️
airflow/executors/base_executor.py 93.42% <0%> (-2.64%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bebe8d...e28f6c8. Read the comment docs.

@ashb ashb merged commit d90ddbd into apache:master Dec 10, 2019
@timkpaine timkpaine deleted the reverse_proxy branch December 10, 2019 14:31
kaxil added a commit that referenced this pull request Dec 17, 2019
kaxil added a commit that referenced this pull request Dec 18, 2019
ashb pushed a commit that referenced this pull request Dec 19, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants