Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6167] Escape column name in create table in hive #6741

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[AIRFLOW-6167] Escape column name in create table in hive #6741

merged 1 commit into from
Dec 6, 2019

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Dec 5, 2019

Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6167
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Hive query will fail if column name contains keyword, unless escaped.
    Fix is always escaping column name when creating table.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@KevinYang21

@KevinYang21
Copy link
Member

LGTM, will stamp once you have a passing CI.

Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.
@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #6741 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6741     +/-   ##
=========================================
- Coverage   84.83%   84.53%   -0.3%     
=========================================
  Files         669      669             
  Lines       37738    37738             
=========================================
- Hits        32014    31901    -113     
- Misses       5724     5837    +113
Impacted Files Coverage Δ
airflow/hooks/hive_hooks.py 77.6% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/utils/dag_processing.py 87.2% <0%> (-0.39%) ⬇️
airflow/jobs/backfill_job.py 91.18% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce873af...1146b08. Read the comment docs.

@KevinYang21 KevinYang21 merged commit a1f3b29 into apache:master Dec 6, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.
kaxil pushed a commit that referenced this pull request Mar 31, 2020
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.

(cherry picked from commit a1f3b29)
kaxil pushed a commit that referenced this pull request Mar 31, 2020
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.

(cherry picked from commit a1f3b29)
kaxil pushed a commit that referenced this pull request Mar 31, 2020
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.

(cherry picked from commit a1f3b29)
kaxil pushed a commit that referenced this pull request Apr 1, 2020
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.

(cherry picked from commit a1f3b29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants