Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Airflow-5144] confirmation dialogue on delete #6745

Conversation

h5chauhan
Copy link
Contributor

As per pallets-eco/flask-admin#1789 the deleted button did not show a confirmation alert. This issue has
been fixed in newer version of flask-admin

Make sure you have checked all steps below.

Jira

  • My PR addresses the following AIRFLOW-5144 issues and references them in the PR title.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Confirmation dialogue on click of delete was not showing up due to Delete confirmation no longer shows in list view pallets-eco/flask-admin#1789 since the fix is now merged this PR upgrades the flask-admin version. I have tested creating and deleting variables and connections on the UI. A screenshot with the confirmation dialogue appearing on delete is attached.

image

Tests

  • My PR add not need testing for this extremely good reason: AFAIK no unit tests exists for UI

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. The subject is separated from the body by a blank line

Documentation

  • This is restoring the functionality of confirmation dialogue before deleting a variable or connection.

As per pallets-eco/flask-admin#1789 the deleted button did not show a confirmation alert. This issue has
been fixed in newer version of flask-admin
@h5chauhan h5chauhan mentioned this pull request Dec 6, 2019
2 tasks
@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #6745 into v1-10-test will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v1-10-test    #6745      +/-   ##
==============================================
+ Coverage       79.69%   79.69%   +<.01%     
==============================================
  Files             518      518              
  Lines           35300    35300              
==============================================
+ Hits            28132    28134       +2     
+ Misses           7168     7166       -2
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 58.86% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beafcee...afe0e7f. Read the comment docs.

@kaxil kaxil merged commit ee4066d into apache:v1-10-test Dec 6, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
As per pallets-eco/flask-admin#1789 the deleted button did not show a confirmation alert. This issue has
been fixed in newer version of flask-admin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants