[Airflow-5144] confirmation dialogue on delete #6745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per pallets-eco/flask-admin#1789 the deleted button did not show a confirmation alert. This issue has
been fixed in newer version of flask-admin
Make sure you have checked all steps below.
Jira
Description
Confirmation dialogue on click of delete was not showing up due to Delete confirmation no longer shows in list view pallets-eco/flask-admin#1789 since the fix is now merged this PR upgrades the flask-admin version. I have tested creating and deleting variables and connections on the UI. A screenshot with the confirmation dialogue appearing on delete is attached.
Tests
Commits
Documentation