-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema #6754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6754 +/- ##
=========================================
- Coverage 84.84% 84.55% -0.3%
=========================================
Files 669 669
Lines 37851 37851
=========================================
- Hits 32114 32004 -110
- Misses 5737 5847 +110
Continue to review full report at Codecov.
|
target_metadata=target_metadata, | ||
literal_binds=True, | ||
compare_type=COMPARE_TYPE, | ||
render_as_batch=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -22,6 +22,7 @@ | |||
from alembic import context | |||
|
|||
from airflow import models, settings | |||
from airflow.models.serialized_dag import SerializedDagModel # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did not realise that was the side effect. Will remember about that!
…embic schema (apache#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d)
…embic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d)
…embic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d)
…embic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d)
…embic schema (apache#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema
…umn to 5000 (apache#6241)" (apache#6783) This reverts commit da7a353. This was already fixed by by apache#6754 which was already merged, and we ended up with two migration files (trying) to do the same thing.
Make sure you have checked all steps below.
Jira
Description
Connection.password
to 5000, syncing with the SQLAlchemy model, and setrender_as_batch=True
for both online & offline migrations to work withSQLite
backend.SerializedDagModel
tomigrations/env.py
. AsSerializedDagModel
was removed frommodels
([AIRFLOW-6010] Remove cyclic imports and pylint disables #6601 ), alembic thinks that the object was removed, and will try to remove the table in autogenerated schema migration. This can avoid the behaviorTests
Commits
Documentation