Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW XXX] Update kubernetes doc with correct path #6774

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

serkef
Copy link
Contributor

@serkef serkef commented Dec 10, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Doc change

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added provider:google Google (including GCP) related issues k8s and removed provider:google Google (including GCP) related issues labels Dec 10, 2019
@potiuk potiuk merged commit 2784372 into apache:master Dec 10, 2019
@potiuk
Copy link
Member

potiuk commented Dec 10, 2019

Thanks!

potiuk pushed a commit that referenced this pull request Dec 10, 2019
potiuk pushed a commit that referenced this pull request Dec 11, 2019
@serkef serkef deleted the patch-1 branch December 11, 2019 11:15
potiuk pushed a commit that referenced this pull request Dec 11, 2019
potiuk pushed a commit that referenced this pull request Dec 12, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
kaxil pushed a commit that referenced this pull request Dec 17, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants