-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6171] Apply .airflowignore to correct subdirectories #6784
Conversation
Fix the defect that applied .airflowignore rules from one subdirectory to all other subdirectories scanned later.
'start_date': DEFAULT_DATE, | ||
} | ||
|
||
dag = DAG(dag_id='test_dag_under_subdir2', default_args=args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually need a dag for the test to work, so this file can be mostly empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be almost empty but this is under the dags folder and we're making this file look like a dag to Airflow so it seems to make sense to place an actual test dag here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no - we're only testing the ignore behaviour, which we test "in isolation" outside of the rest of the scheduler. Anyway, let's put schedule_interval=None
then please so that this doesn't actually run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, small change requested though please.
Codecov Report
@@ Coverage Diff @@
## master #6784 +/- ##
==========================================
- Coverage 84.53% 84.29% -0.24%
==========================================
Files 672 672
Lines 38153 38219 +66
==========================================
- Hits 32252 32218 -34
- Misses 5901 6001 +100
Continue to review full report at Codecov.
|
…#6784) Fix the defect that applied .airflowignore rules from one subdirectory to all other subdirectories scanned later.
Fix the defect that applied .airflowignore rules from one subdirectory
to all other subdirectories scanned later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation