[AIRFLOW-5463] Use same session to delete and add variable in set #6807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged.
Codecov Report
@@ Coverage Diff @@
## master #6807 +/- ##
==========================================
- Coverage 84.58% 84.53% -0.05%
==========================================
Files 672 673 +1
Lines 38220 38863 +643
==========================================
+ Hits 32329 32854 +525
- Misses 5891 6009 +118
Continue to review full report at Codecov.
|
kaxil
pushed a commit
that referenced
this pull request
Dec 17, 2019
) Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged. (cherry picked from commit 5483ae4)
ashb
pushed a commit
that referenced
this pull request
Dec 17, 2019
) Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged. (cherry picked from commit 5483ae4)
ashb
pushed a commit
that referenced
this pull request
Dec 19, 2019
) Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged. (cherry picked from commit 5483ae4)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…ache#6807) Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
resulting in the variable being deleted. The intention of this change is
that an error should leave the variable unchanged.
https://issues.apache.org/jira/browse/AIRFLOW-5463
Tests
I was unable to see a good way to test this, is there a way to make delete succeed and add error? You could consider it a refactoring since the variable tests continue to pass.