-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4824] Add charset handling for SqlAlchemy engine for MySqlHook #6816
Conversation
Airflow should handle various charsets for connections with MySQL dbs. This change allows to set charset in extra field of a connection when using SqlAlchemy engine.
Codecov Report
@@ Coverage Diff @@
## master #6816 +/- ##
==========================================
- Coverage 84.45% 84.31% -0.14%
==========================================
Files 676 676
Lines 38310 38317 +7
==========================================
- Hits 32354 32307 -47
- Misses 5956 6010 +54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zuku1985 - yet another result of the workshop! :)
…ok (apache#6816) Airflow should handle various charsets for connections with MySQL dbs. This change allows to set charset in extra field of a connection when using SqlAlchemy engine.
Airflow should handle various charsets for connections with MySQL dbs.
This change allows to set charset in extra field of a connection when
using SqlAlchemy engine.
Make sure you have checked all steps below.
Jira
Description
Airflow should handle various charsets for connections with MySQL dbs.
This change allows to set charset in extra field of a connection when
using SqlAlchemy engine.
Tests
test_get_uri in TestMySqlHookConn
Commits
Documentation