-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3189] Remove schema from get_uri response if None #6833
Conversation
"None" was appended to uri if schema=None. Check was added if schema is None.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one !
Codecov Report
@@ Coverage Diff @@
## master #6833 +/- ##
========================================
- Coverage 84.59% 84.3% -0.3%
========================================
Files 676 676
Lines 38337 38361 +24
========================================
- Hits 32433 32342 -91
- Misses 5904 6019 +115
Continue to review full report at Codecov.
|
Nice one ! Thanks @zuku1985 ! |
"None" was appended to uri if schema=None. Check was added if schema is None. (cherry picked from commit e3bd2a2)
Also cherry-picked to 1.10.7 |
"None" was appended to uri if schema=None. Check was added if schema is None. (cherry picked from commit e3bd2a2)
"None" was appended to uri if schema=None. Check was added if schema is None. (cherry picked from commit e3bd2a2)
"None" was appended to uri if schema=None. Check was added if schema is None. (cherry picked from commit e3bd2a2)
"None" was appended to uri if schema=None. Check was added if schema is None.
"None" was appended to uri if schema=None. Check was added if schema is None.
"None" was appended to URI if schema=None. A check was added if
schema is None.
Make sure you have checked all steps below.
Jira
Description
In DbApiHook method get_uri "None" was appended to uri when schema was not set. This PR adds check if schema is None.
Tests
test_get_uri_schema_not_none and test_get_uri_schema_none in TestDbApiHook
Commits
Documentation