-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6271] Printing log files read during load_test_config #6842
[AIRFLOW-6271] Printing log files read during load_test_config #6842
Conversation
Airflow should show where the configuration is read from. Especially for new user it might be confusing as it is not logged anywhere and there are several places the configuration might be read from. This is printed for the main config file, but not when load_test_config is used.
Codecov Report
@@ Coverage Diff @@
## master #6842 +/- ##
==========================================
- Coverage 84.49% 84.21% -0.29%
==========================================
Files 680 680
Lines 38392 38395 +3
==========================================
- Hits 32441 32335 -106
- Misses 5951 6060 +109
Continue to review full report at Codecov.
|
@@ -430,10 +430,13 @@ def load_test_config(self): | |||
Note: this is not reversible. | |||
""" | |||
# override any custom settings with defaults | |||
log.info("Overriding settings with defaults from %s", DEFAULT_CONFIG_FILE_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be debug -- it's a bit too noisy and not useful to see this all the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nm, this is load_test_config only :)
Airflow should show where the configuration is read from. Especially for new user it might be confusing as it is not logged anywhere and there are several places the configuration might be read from. This is printed for the main config file, but not when load_test_config is used. (cherry picked from commit 81de282)
Airflow should show where the configuration is read from. Especially for new user it might be confusing as it is not logged anywhere and there are several places the configuration might be read from. This is printed for the main config file, but not when load_test_config is used. (cherry picked from commit 81de282)
…e#6842) Airflow should show where the configuration is read from. Especially for new user it might be confusing as it is not logged anywhere and there are several places the configuration might be read from. This is printed for the main config file, but not when load_test_config is used.
…e#6842) Airflow should show where the configuration is read from. Especially for new user it might be confusing as it is not logged anywhere and there are several places the configuration might be read from. This is printed for the main config file, but not when load_test_config is used.
Airflow should show where the configuration is read from. Especially for new
user it might be confusing as it is not logged anywhere and there are several
places the configuration might be read from.
This is printed for the main config file, but not when load_test_config is used.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation