Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-4113] Unpin boto3 #6884

Merged
merged 5 commits into from
Dec 24, 2019
Merged

[AIRFLOW-4113] Unpin boto3 #6884

merged 5 commits into from
Dec 24, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Dec 23, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Right now we're pinning boto on <1.8 because of an underlying issue in moto. This issue has been solved, and therefore it would be nice to update again to a more recent version of boto.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested a review from ashb December 23, 2019 17:52
@kaxil kaxil force-pushed the unpin-boto branch 2 times, most recently from 1c0b39e to 8897547 Compare December 23, 2019 17:54
@kaxil kaxil mentioned this pull request Dec 23, 2019
Closed
6 tasks
@kaxil kaxil changed the title [AIRFLOW-4113] Unpin boto3 WIP: [AIRFLOW-4113] Unpin boto3 Dec 23, 2019
@kaxil kaxil changed the title WIP: [AIRFLOW-4113] Unpin boto3 [AIRFLOW-4113] Unpin boto3 Dec 24, 2019
@kaxil
Copy link
Member Author

kaxil commented Dec 24, 2019

CI Passed: https://travis-ci.com/astronomer/airflow/builds/142182607?

@kaxil kaxil requested a review from potiuk December 24, 2019 12:59
ashb
ashb requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

setup.py Outdated
@@ -380,7 +380,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
'ipdb',
'jira',
'mongomock',
'moto==1.3.5',
'moto>=1.3.14',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to disallow Moto 2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@kaxil kaxil merged commit e0c6d86 into apache:master Dec 24, 2019
@kaxil kaxil deleted the unpin-boto branch December 24, 2019 14:04
potiuk pushed a commit that referenced this pull request Jan 21, 2020
@kaxil @potiuk
[AIRFLOW-4113] Unpin boto3 (#6884)
06049fc 
(cherry picked from commit e0c6d86)
kaxil added a commit that referenced this pull request Jan 22, 2020
@kaxil
[AIRFLOW-4113] Unpin boto3 (#6884)
9863c10 
(cherry picked from commit e0c6d86)
kaxil added a commit that referenced this pull request Jan 22, 2020
@kaxil
fixup! [AIRFLOW-4113] Unpin boto3 (#6884)
adcebe2
kaxil added a commit that referenced this pull request Jan 23, 2020
@kaxil
[AIRFLOW-4113] Unpin boto3 (#6884)
f7035a3 
(cherry picked from commit e0c6d86)
kaxil added a commit that referenced this pull request Jan 23, 2020
@kaxil
fixup! [AIRFLOW-4113] Unpin boto3 (#6884)
01e06f9
potiuk pushed a commit that referenced this pull request Jan 26, 2020
@kaxil @potiuk
[AIRFLOW-4113] Unpin boto3 (#6884)
b82196c 
(cherry picked from commit e0c6d86)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@kaxil @galuszkak
[AIRFLOW-4113] Unpin boto3 (apache#6884)
412b682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

@potiuk potiuk Awaiting requested review from potiuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxil @ashb