Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6351] security - ui - Add Cross Site Scripting defence #6913

Merged
merged 2 commits into from
Dec 27, 2019
Merged

[AIRFLOW-6351] security - ui - Add Cross Site Scripting defence #6913

merged 2 commits into from
Dec 27, 2019

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Dec 26, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@turbaszek
Copy link
Member

turbaszek commented Dec 26, 2019

@tooptoop4 in Airflow we use amazing pre-commit framework that allow us to run all static analysis before committing. By using it you will eliminate need for refactoring your code and more importantly resources of our CI will be used more efficiently.
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#enabling-pre-commit-hooks

@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Dec 26, 2019

@nuclearpinguin k, maybe docs need update as brew install xmllint does not work on Mac but brew install libxml2 works. Full steps I needed to get the checks:
(assuming brew and pip already installed)
pip install pre-commit
brew install gnu-getopt coreutils
echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.bash_profile;. ~/.bash_profile
brew cask install docker
run docker from Applications

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #6913 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6913   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         679      679           
  Lines       38505    38505           
=======================================
  Hits        32623    32623           
  Misses       5882     5882
Impacted Files Coverage Δ
airflow/www/views.py 76.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fffa5b...c6d13c1. Read the comment docs.

@potiuk potiuk merged commit cf36cd9 into apache:master Dec 27, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants