-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6348] security - cli.py is currently printing logs with pass… #6915
Conversation
…word if you use cli to add connection with conn_password
travis unrelated? |
Codecov Report
@@ Coverage Diff @@
## master #6915 +/- ##
=========================================
- Coverage 84.72% 84.5% -0.23%
=========================================
Files 679 679
Lines 38505 39084 +579
=========================================
+ Hits 32623 33027 +404
- Misses 5882 6057 +175
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -86,7 +86,7 @@ def connections_add(args): | |||
urlunparse((args.conn_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use Connection.get_uri method here?
…word if you use cli to add connection with conn_password
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation