-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5149] - skip SLA checks config #6923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6923 +/- ##
==========================================
- Coverage 84.71% 84.42% -0.29%
==========================================
Files 679 679
Lines 38508 38519 +11
==========================================
- Hits 32622 32521 -101
- Misses 5886 5998 +112
Continue to review full report at Codecov.
|
Co-Authored-By: Kaxil Naik <[email protected]>
* [AIRFLOW-5149] - skip SLA checks config (cherry picked from commit 7d97d16)
@@ -176,6 +176,9 @@ store_serialized_dags = False | |||
# Updating serialized DAG can not be faster than a minimum interval to reduce database write rate. | |||
min_serialized_dag_update_interval = 30 | |||
|
|||
# On each dagrun check against defined SLAs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some documentation about this option? If there is no information about this feature in the documentation, very few people will be able to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mik-laj - > where do you think the documentation should be added ? Maybe you can provide some pointers? Most of the config options are documented in comments of the default_airlfow.cfg. Any other specific place you think this documentation should be added (and where all the previous options are documented?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and where all the previous options are documented?
We have documentation gaps, but we try to develop documentation all the time. There is no precise documentation for the SLA mechanism, but this does not mean that it is impossible to write a few sentences and put them in the documentation. Another person who wants to describe the wider documentation will have less work.
I think that these two sentences describing this parameter may be placed in a new document in the howto directory. I will give an example of documentation that describes the configuration parameter.
https://github.com/apache/airflow/pull/5850/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created at #6974
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaxil Fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [AIRFLOW-5149] - skip SLA checks config (cherry picked from commit 7d97d16)
* [AIRFLOW-5149] - skip SLA checks config
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation