Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5149] - skip SLA checks config #6923

Merged
merged 4 commits into from
Dec 28, 2019
Merged

[AIRFLOW-5149] - skip SLA checks config #6923

merged 4 commits into from
Dec 28, 2019

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Dec 27, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #6923 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6923      +/-   ##
==========================================
- Coverage   84.71%   84.42%   -0.29%     
==========================================
  Files         679      679              
  Lines       38508    38519      +11     
==========================================
- Hits        32622    32521     -101     
- Misses       5886     5998     +112
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 89.28% <100%> (+0.01%) ⬆️
airflow/contrib/hooks/cassandra_hook.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/models/__init__.py 91.3% <0%> (-8.7%) ⬇️
airflow/contrib/hooks/spark_submit_hook.py 82% <0%> (-0.72%) ⬇️
airflow/models/taskinstance.py 94.91% <0%> (+0.43%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b4446...a986519. Read the comment docs.

@tooptoop4 tooptoop4 requested a review from kaxil December 28, 2019 09:57
@potiuk potiuk merged commit 7d97d16 into apache:master Dec 28, 2019
potiuk pushed a commit that referenced this pull request Dec 30, 2019
* [AIRFLOW-5149] - skip SLA checks config

(cherry picked from commit 7d97d16)
@@ -176,6 +176,9 @@ store_serialized_dags = False
# Updating serialized DAG can not be faster than a minimum interval to reduce database write rate.
min_serialized_dag_update_interval = 30

# On each dagrun check against defined SLAs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some documentation about this option? If there is no information about this feature in the documentation, very few people will be able to use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-laj - > where do you think the documentation should be added ? Maybe you can provide some pointers? Most of the config options are documented in comments of the default_airlfow.cfg. Any other specific place you think this documentation should be added (and where all the previous options are documented?)

Copy link
Member

@mik-laj mik-laj Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and where all the previous options are documented?

We have documentation gaps, but we try to develop documentation all the time. There is no precise documentation for the SLA mechanism, but this does not mean that it is impossible to write a few sentences and put them in the documentation. Another person who wants to describe the wider documentation will have less work.

I think that these two sentences describing this parameter may be placed in a new document in the howto directory. I will give an example of documentation that describes the configuration parameter.
https://github.com/apache/airflow/pull/5850/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created at #6974

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaxil Fantastic!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @mik-laj and @kaxil for explaining and adding :).

potiuk pushed a commit that referenced this pull request Jan 21, 2020
* [AIRFLOW-5149] - skip SLA checks config

(cherry picked from commit 7d97d16)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* [AIRFLOW-5149] - skip SLA checks config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants