Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6370] Skip Cassandra tests if cluster is not up #6926

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR add skipIf decorator for Cassandra hook tests and improves mocking in sensors tests. The decorator should eliminate flaky tests.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #6926 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6926     +/-   ##
=========================================
- Coverage   84.72%   84.42%   -0.3%     
=========================================
  Files         679      679             
  Lines       38518    38518             
=========================================
- Hits        32634    32519    -115     
- Misses       5884     5999    +115
Impacted Files Coverage Δ
airflow/contrib/hooks/cassandra_hook.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/jobs/backfill_job.py 91.59% <0%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f86df0...23de381. Read the comment docs.

@potiuk potiuk merged commit 2ee349d into apache:master Dec 27, 2019
potiuk pushed a commit that referenced this pull request Dec 27, 2019
@turbaszek
Copy link
Member Author

It seems that the problem persists:
https://travis-ci.org/apache/airflow/jobs/630369640

The test is not skipped so connection can be established? Default port is used in both cases.

@potiuk @mik-laj do you have any ideas?

@potiuk
Copy link
Member

potiuk commented Dec 28, 2019

I restarted it too quickly. I will take a look next time it happens (or maybe we manage to move to github before ;)

potiuk pushed a commit that referenced this pull request Dec 29, 2019
potiuk pushed a commit to PolideaInternal/airflow that referenced this pull request Dec 29, 2019
potiuk pushed a commit that referenced this pull request Dec 30, 2019
potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 22, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@turbaszek turbaszek deleted the AIRFLOW-6370-cassandra-tests branch March 14, 2020 23:35
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2020
(cherry picked from commit 2ee349d)
(cherry picked from commit 7d9c4ff)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2020
(cherry picked from commit 2ee349d)
(cherry picked from commit ee0e45f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants