Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4428] error if exec_date before default_args.start_date in t… #6948

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Dec 29, 2019

…rigger_dag

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #6948 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6948      +/-   ##
==========================================
- Coverage    84.7%   84.56%   -0.14%     
==========================================
  Files         680      679       -1     
  Lines       38556    38540      -16     
==========================================
- Hits        32659    32592      -67     
- Misses       5897     5948      +51
Impacted Files Coverage Δ
airflow/api/common/experimental/trigger_dag.py 97.95% <100%> (+0.18%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/utils/file.py 86.3% <0%> (-5.17%) ⬇️
airflow/utils/cli.py 68.75% <0%> (-2.95%) ⬇️
airflow/utils/helpers.py 81.69% <0%> (-1.06%) ⬇️
airflow/cli/commands/dag_command.py 86.2% <0%> (-0.51%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d97d16...2fbbaf7. Read the comment docs.

@potiuk
Copy link
Member

potiuk commented Dec 29, 2019

Nice one. How about adding a test for that @tooptoop4 ?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test

@tooptoop4 tooptoop4 requested a review from potiuk January 1, 2020 22:25
@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Jan 1, 2020

@potiuk tests added, pls merge

@tooptoop4
Copy link
Contributor Author

@potiuk gentle ping

@potiuk potiuk merged commit 41a9bfd into apache:master Jan 6, 2020
@potiuk
Copy link
Member

potiuk commented Jan 6, 2020

@tooptoop4 - are you sure that the issue id was correct in this one ?

@potiuk
Copy link
Member

potiuk commented Jan 6, 2020

This looks like completely different issue: https://issues.apache.org/jira/browse/AIRFLOW-4428

@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Jan 6, 2020

@potiuk it is right jira, comments in jira explain the reasoning

@potiuk
Copy link
Member

potiuk commented Jan 6, 2020

OK. I see it now. The confusion was due to one of the links in the PR did not have JIRA_ID and opened another issue. then I copied the other link :)

potiuk pushed a commit that referenced this pull request Jan 21, 2020
potiuk added a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 22, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants