Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-6387] print details of success/skipped task #6956

Merged
merged 5 commits into from
Jan 6, 2020
Merged

[AIRFLOW-6387] print details of success/skipped task #6956

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
151f8ee
[AIRFLOW-6387] print details of success/skipped task
tooptoop4 Dec 29, 2019
b2d8305
need end_date set
tooptoop4 Jan 1, 2020
21bcc37
dates can be none
tooptoop4 Jan 1, 2020
341f976
add comment
tooptoop4 Jan 1, 2020
3bdf12d
remove try/except
tooptoop4 Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,11 +964,26 @@ def signal_handler(signum, frame):
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
except AirflowSkipException as e:
# Recording SKIP
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
self.log.info(
'Marking task as SKIPPED.'
'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
self.dag_id,
self.task_id,
self.execution_date.strftime('%Y%m%dT%H%M%S') if hasattr(
self,
'execution_date') and self.execution_date else '',
self.start_date.strftime('%Y%m%dT%H%M%S') if hasattr(
self,
'start_date') and self.start_date else '',
self.end_date.strftime('%Y%m%dT%H%M%S') if hasattr(
self,
'end_date') and self.end_date else '')
except AirflowRescheduleException as reschedule_exception:
self.refresh_from_db()
self._handle_reschedule(actual_start_date, reschedule_exception, test_mode, context)
Expand Down Expand Up @@ -996,6 +1011,14 @@ def signal_handler(signum, frame):

# Recording SUCCESS
self.end_date = timezone.utcnow()
self.log.info(
'Marking task as SUCCESS.'
'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
self.dag_id,
self.task_id,
self.execution_date.strftime('%Y%m%dT%H%M%S') if self.execution_date else '',
self.start_date.strftime('%Y%m%dT%H%M%S') if self.start_date else '',
self.end_date.strftime('%Y%m%dT%H%M%S') if self.end_date else '')
self.set_duration()
if not test_mode:
session.add(Log(self.state, self))
Expand Down