Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4 #6976

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Dec 31, 2019

@tooptoop4
Copy link
Contributor Author

@potiuk this is same as #6911 but using standard assert

@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #6976 into master will decrease coverage by 0.19%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6976     +/-   ##
=========================================
- Coverage   84.74%   84.54%   -0.2%     
=========================================
  Files         679      679             
  Lines       38495    38504      +9     
=========================================
- Hits        32622    32553     -69     
- Misses       5873     5951     +78
Impacted Files Coverage Δ
airflow/contrib/hooks/spark_submit_hook.py 84.61% <85.71%> (+2.54%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/jobs/backfill_job.py 91.88% <0%> (+0.28%) ⬆️
airflow/hooks/postgres_hook.py 94.36% <0%> (+1.4%) ⬆️
airflow/hooks/dbapi_hook.py 91.73% <0%> (+1.65%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991b34d...46ecb36. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You just need to rebase :)

@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Dec 31, 2019

@potiuk conflict resolved, pls merge

@potiuk potiuk merged commit 071810a into apache:master Dec 31, 2019
@potiuk
Copy link
Member

potiuk commented Dec 31, 2019

Thanks @tooptoop4 !

potiuk pushed a commit that referenced this pull request Dec 31, 2019
kaxil pushed a commit that referenced this pull request Jan 10, 2020
potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants