[AIRFLOW-6413] Add config file for Mergeable Github integration #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
changed the title
kaxil
changed the title
potiuk
approved these changes
Dec 31, 2019
kaxil
changed the title
kaxil
force-pushed
the
add-mergeable-config
branch
from
16f312f
to
8dd300e
Compare
kaxil
force-pushed
the
add-mergeable-config
branch
from
8dd300e
to
4132612
Compare
kaxil
added a commit
that referenced
this pull request
Dec 31, 2019
(cherry picked from commit 991b34d)
ashb
reviewed
Dec 31, 2019
| begins_with: | ||
| match: '[AIRFLOW-' | ||
| must_include: | ||
| regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\]) |
There was a problem hiding this comment.
This should be AIRFLOW-XXX not XXXX :)
There was a problem hiding this comment.
:D This was intentional as there was a recent change in Github PR template that asked users to add 4 X's [AIRFLOW-XXXX] for docs.
There was a problem hiding this comment.
That reminds you that if you have XXX in the release scripts to distinguish doc-only updates, it should be updated to support also XXXX (maybe - depends if you have in search pattern "]" ;)
There was a problem hiding this comment.
BTW. I really love that people will have to manually click the checkboxes now (though initially people won't understand why mergable complains). Happened already with @michalslowikowski00 :D. But I think this is good if they ask.
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config for https://github.com/apps/mergeable
Jira: https://issues.apache.org/jira/browse/AIRFLOW-6413
[AIRFLOW-XXXX]for document-only changesIn case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.