[AIRFLOW-6381] Remove styling based on DAG id from DAGs page #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something is wrong with this change. It contains a huge amount of commit. Can you fix it? |
|
I have updated the base so should be fine now. |
kaxil
reviewed
Jan 6, 2020
| @@ -88,7 +88,7 @@ <h2>DAGs</h2> | |||
|
|
|||
| <!-- Column 4: Dag Schedule --> | |||
| <td> | |||
| <a class="label label-default schedule {{ dag.dag_id }}" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}"> | |||
There was a problem hiding this comment.
@mik-laj Do you know if we have custom CSS somewhere based on DAG ID
There was a problem hiding this comment.
Don't think we do as dag_id can be literally anything!
There was a problem hiding this comment.
I've seen it before, but I believed it had a purpose. :-D
kaxil
approved these changes
Jan 6, 2020
|
Waiting for the CI to pass before I merge |
|
Thank you @kaxil! |
|
Awesome work, congrats on your first merged pull request! |
kaxil
pushed a commit
that referenced
this pull request
Jan 23, 2020
potiuk
pushed a commit
that referenced
this pull request
Jan 26, 2020
kaxil
pushed a commit
that referenced
this pull request
Jan 26, 2020
kaxil
pushed a commit
that referenced
this pull request
Feb 3, 2020
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6381
[AIRFLOW-XXXX]for document-only changesIn case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.