Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6418] Remove SystemTest.skip decorator #6991

Merged
merged 1 commit into from
Jan 1, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 1, 2020

Instead of forcing the user to use a decorator, we can override the "run" method in the class.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #6991 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6991      +/-   ##
==========================================
- Coverage   84.85%   84.56%   -0.29%     
==========================================
  Files         679      679              
  Lines       38536    38536              
==========================================
- Hits        32698    32588     -110     
- Misses       5838     5948     +110
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7a97d...f80776b. Read the comment docs.

@potiuk potiuk merged commit 6c2a0d4 into apache:master Jan 1, 2020
potiuk pushed a commit that referenced this pull request Jan 1, 2020
kaxil pushed a commit that referenced this pull request Jan 10, 2020
potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
(cherry picked from commit 6c2a0d4)
(cherry picked from commit 1125d3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants