[AIRFLOW-6434] Add return back to DockerOperator.execute #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests to prevent regression? |
|
@mik-laj added a test for expected behavior |
mik-laj
approved these changes
Jan 3, 2020
kaxil
added a commit
that referenced
this pull request
Jan 23, 2020
kaxil
added a commit
that referenced
this pull request
Jan 24, 2020
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/AIRFLOW-6434
This change (8a6dc66) introduced a slight (and I believe unintended) change to the Docker Operator xcom behavior. Even if xcom_push is True, DockerOperator.execute will not return a value and thus will not push an xcom value.