Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6436] Cleanup for Airflow Configs doc generator code #7036

Merged
merged 3 commits into from
Jan 4, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 4, 2020

Follow Up of #7015 to cleanup code


Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6436

  • Description above provides context of the change
  • Commit message starts with [AIRFLOW-NNNN], where AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

(*) For document-only changes, no JIRA issue is needed. Commit message starts [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #7036 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7036      +/-   ##
=========================================
+ Coverage   84.68%   84.7%   +0.02%     
=========================================
  Files         680     679       -1     
  Lines       38686   38647      -39     
=========================================
- Hits        32761   32737      -24     
+ Misses       5925    5910      -15
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/hooks/dbapi_hook.py 91.73% <0%> (+0.82%) ⬆️
airflow/models/connection.py 68.78% <0%> (+0.97%) ⬆️
airflow/hooks/hive_hooks.py 77.55% <0%> (+1.53%) ⬆️
airflow/utils/sqlalchemy.py 96.66% <0%> (+6.66%) ⬆️
airflow/operators/mysql_operator.py 100% <0%> (+100%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d82e8c...4e2cd61. Read the comment docs.

@kaxil
Copy link
Member Author

kaxil commented Jan 4, 2020

@kaxil kaxil merged commit 09c895e into apache:master Jan 4, 2020
@kaxil kaxil deleted the config-automation-cleanup branch January 4, 2020 16:18
kaxil added a commit that referenced this pull request Jan 11, 2020
potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil added a commit that referenced this pull request Jan 23, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants