Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6456] Remove create_mock_args in CLI tests #7044

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 4, 2020

In all other tests we use a different convention for creating args object.


Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6456

  • Description above provides context of the change
  • Commit message starts with [AIRFLOW-NNNN], where AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

(*) For document-only changes, no JIRA issue is needed. Commit message starts [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #7044 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
- Coverage   85.01%   84.86%   -0.16%     
==========================================
  Files         680      680              
  Lines       38748    38952     +204     
==========================================
+ Hits        32942    33057     +115     
- Misses       5806     5895      +89
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/utils/log/file_processor_handler.py 85.33% <0%> (-2.67%) ⬇️
airflow/jobs/backfill_job.py 91.59% <0%> (-0.29%) ⬇️
airflow/jobs/local_task_job.py 89.74% <0%> (+0.41%) ⬆️
airflow/gcp/hooks/bigquery.py 90.71% <0%> (+2.36%) ⬆️
airflow/models/baseoperator.py 98.76% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c7d17...dfa0970. Read the comment docs.

@mik-laj mik-laj merged commit 8807ff4 into apache:master Jan 6, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants