-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6471] Add pytest-instafail plugin #7064
[AIRFLOW-6471] Add pytest-instafail plugin #7064
Conversation
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity.
This is how it will look like - no more disappearing test failures after the build times out. I think it removes the need of decreasing the timeout (which can lead to some unnecessary errors when a test runs significantly longer than usual) and increasing pytest verbosity (when a test fail we will immediately see all necessary details to see what was going on). |
Codecov Report
@@ Coverage Diff @@
## master #7064 +/- ##
=========================================
- Coverage 84.76% 84.7% -0.07%
=========================================
Files 679 679
Lines 38647 38647
=========================================
- Hits 32761 32736 -25
- Misses 5886 5911 +25
Continue to review full report at Codecov.
|
@potiuk https://travis-ci.org/apache/airflow/jobs/632996416?utm_medium=notification&utm_source=github_status gave no details, just timeout |
It succeeded now I think! |
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96)
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96)
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96)
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96)
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96)
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity.
We have a problem currently that if a test fails in CI we do not see the failures immediately - only when it finishes, but when tests hang, sometimes the details about failed tests are not shown immediately. We tried to increase verbosity but it's not very helpful. The pytest-instafail plugin solves the problem without increasing verbosity. (cherry picked from commit 869ca96) (cherry picked from commit bab5551)
We have a problem currently that if a test fails in CI we do not see the
failures immediately - only when it finishes, but when tests hang, sometimes
the details about failed tests are not shown immediately. We tried to increase
verbosity but it's not very helpful.
The pytest-instafail plugin solves the problem without increasing verbosity.
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6471
[AIRFLOW-NNNN]
, where AIRFLOW-NNNN = JIRA ID*(*) For document-only changes, no JIRA issue is needed. Commit message starts
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.