[AIRFLOW-6489] Add BATS support for Bash unit testing #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning to write tests for some core code, or will it be only for testing the development environment - Breeze? |
|
I am planning to first introduce it for Breeze (that's where it is needed badly) but anyone (including myself) can add tests for all the other bash scripts. |
|
For sure I will need it for build/ci scripts simplification in order to add production image support finally. This really prerequisite as it becomes more and more complex to make change without bash unit tests. |
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon).
potiuk
force-pushed
the
AIRFLOW-6498-bats-automated-bash-unit-testing
branch
from
62c4fef
to
6cdcc01
Compare
|
All green. Would love to merge that in order to continue working on prod image changes. |
This was referenced Jan 6, 2020
mik-laj
approved these changes
Jan 7, 2020
potiuk
added a commit
that referenced
this pull request
Jan 21, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon). (cherry picked from commit 2b37472)
kaxil
pushed a commit
that referenced
this pull request
Jan 22, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon). (cherry picked from commit 2b37472)
kaxil
pushed a commit
that referenced
this pull request
Jan 23, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon). (cherry picked from commit 2b37472)
potiuk
added a commit
that referenced
this pull request
Jan 26, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon). (cherry picked from commit 2b37472)
kaxil
pushed a commit
that referenced
this pull request
Jan 26, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon). (cherry picked from commit 2b37472)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
We have far too much bash code around that is not automatically tested. This is the first step to change it (simplifications and more tests are coming soon).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have far too much bash code around that is not automatically tested.
This is the first step to change it (simplifications and more tests are coming
soon).
Issue link: AIRFLOW-6489
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.