Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6490] Improve time delta comparison in local task job tests #7083

Merged

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Jan 6, 2020

This PR eliminates small flakiness from local task job test that occurs when something happens faster"

AssertionError: 1.996401 not greater than or equal to 2

Issue link: AIRFLOW-6490

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jan 6, 2020
@turbaszek turbaszek requested a review from potiuk January 6, 2020 18:20
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #7083 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7083      +/-   ##
==========================================
- Coverage   84.98%   84.78%   -0.21%     
==========================================
  Files         680      680              
  Lines       38753    38753              
==========================================
- Hits        32935    32856      -79     
- Misses       5818     5897      +79
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️
airflow/jobs/backfill_job.py 91.88% <0%> (+1.15%) ⬆️
airflow/contrib/operators/ssh_operator.py 84.61% <0%> (+1.28%) ⬆️
airflow/hooks/postgres_hook.py 94.36% <0%> (+1.4%) ⬆️
airflow/hooks/dbapi_hook.py 91.73% <0%> (+1.65%) ⬆️
airflow/utils/sqlalchemy.py 96.66% <0%> (+1.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64204d3...421c739. Read the comment docs.

@turbaszek turbaszek requested a review from mik-laj January 9, 2020 12:23
@turbaszek turbaszek force-pushed the AIRFLOW-6490-test-improvement branch from 421c739 to 7e277c7 Compare January 9, 2020 12:47
@turbaszek turbaszek merged commit 2754427 into apache:master Jan 9, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk added a commit that referenced this pull request Jan 25, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@turbaszek turbaszek deleted the AIRFLOW-6490-test-improvement branch March 14, 2020 23:34
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants