-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6504] Allow specifying configmap for Airflow Local Setting #7097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7097 +/- ##
==========================================
+ Coverage 85.15% 85.15% +<.01%
==========================================
Files 680 680
Lines 38824 38832 +8
==========================================
+ Hits 33061 33069 +8
Misses 5763 5763
Continue to review full report at Codecov.
|
Hello @kaxil Can you elaborate on why you would want to call pod_mutating_hook inside of a newly launched pod? |
We set tolerations and affinity inside the pod_mutation_hook for the PODs launched by KubernetesPodOperator and KuberneteExecutor. Without this PR, if we are using KubernetesExecutor and have a task with KubernetesPodOperator, the k8s worker pod won't have airflow_local_settings file and so tolerations and affinity won't be applied there. |
Currently
airflow.cfg
file can be passed via ConfigMap usingairflow_configmap
under[kubernetes]
section setting.We want to be able to specify
airflow_local_settings.py
via configmap too so that the Kubernetes Worker has this file. We needairflow_local_settings.py
to specify pod_mutation_hook.Without that currently, if we are using
KubernetesExecutor
and have a task withKubernetesPodOperator
, it will inherit and change Pod usingpod_mutation_hook
Issue link: AIRFLOW-6504
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.