[AIRFLOW-6516] BugFix: airflow.cfg does not exist in Volume Mounts #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache@4748a51 introduced a bug because we were re-assigning the "airflow-config" key in volume_mounts/ Because of this `airflow.cfg` was not mounted and only `airflow_local_settings.py` was mounted if the `airflow_local_settings_configmap` is also set.
|
ohhh ok so you were overwriting |
dimberman
approved these changes
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #7109 +/- ##
======================================
Coverage 85.2% 85.2%
======================================
Files 682 682
Lines 38996 38996
======================================
Hits 33228 33228
Misses 5768 5768
Continue to review full report at Codecov.
|
kaxil
added a commit
to kaxil/airflow
that referenced
this pull request
Feb 24, 2020
…ocal_settings.py (apache#7109)
6 tasks
dimberman
pushed a commit
that referenced
this pull request
Feb 24, 2020
#7518) * [AIRFLOW-6516] Allow different configmaps for airflow.cfg & airflow_local_settings.py (#7109) * Update test_worker_configuration.py
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
apache#7518) * [AIRFLOW-6516] Allow different configmaps for airflow.cfg & airflow_local_settings.py (apache#7109) * Update test_worker_configuration.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4748a51 introduced a bug because we were re-assigning the "airflow-config" key in volume_mounts/
Because of this
airflow.cfgwas not mounted and onlyairflow_local_settings.pywas mounted if theairflow_local_settings_configmapis also set.Issue link: AIRFLOW-6516
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.