[AIRFLOW-XXXX] improve clarity of confirm message #7110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
changed the title
:D |
potiuk
approved these changes
Jan 9, 2020
potiuk
pushed a commit
that referenced
this pull request
Jan 21, 2020
(cherry picked from commit d1c7f3c)
kaxil
pushed a commit
that referenced
this pull request
Jan 22, 2020
(cherry picked from commit d1c7f3c)
kaxil
pushed a commit
that referenced
this pull request
Jan 23, 2020
(cherry picked from commit d1c7f3c)
potiuk
pushed a commit
that referenced
this pull request
Jan 26, 2020
(cherry picked from commit d1c7f3c)
kaxil
pushed a commit
that referenced
this pull request
Jan 26, 2020
(cherry picked from commit d1c7f3c)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies confirm messaging
Before:
After
Why?
The sentence
Forcing response 'no' to rebuild CIcan mean "forcing response "no" in order to rebuild CI -- i.e. we must rebuild CI, and to do so, we must force the answer no.Adding quotes and question mark makes it clear that we are forcing "no" to the question "should we rebuild ci?".
Issue link:
Document only change, no JIRA issue[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.