Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6519] Make TI logs constants in Webserver configurable #7113

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 9, 2020

Some of the TaskInstance logs constants in the webserver (in ti_log.html) can be made configurable.


Issue link: AIRFLOW-6519

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from ashb January 9, 2020 14:16
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 9, 2020
@schnie
Copy link
Contributor

schnie commented Jan 9, 2020

Awesome, this will be a good use for the new helm upgrader hook. We can set a higher value here and push it out to all deployments.

@codecov-io
Copy link

Codecov Report

Merging #7113 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7113      +/-   ##
==========================================
+ Coverage   85.04%   85.22%   +0.17%     
==========================================
  Files         682      682              
  Lines       39000    39000              
==========================================
+ Hits        33169    33236      +67     
+ Misses       5831     5764      -67
Impacted Files Coverage Δ
airflow/www/app.py 94.02% <ø> (ø) ⬆️
airflow/jobs/scheduler_job.py 89.29% <0%> (+1.17%) ⬆️
airflow/utils/sqlalchemy.py 96.66% <0%> (+6.66%) ⬆️
airflow/utils/dag_processing.py 87.95% <0%> (+6.88%) ⬆️
airflow/utils/helpers.py 81.69% <0%> (+7.18%) ⬆️
airflow/executors/sequential_executor.py 88% <0%> (+32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70af358...536a753. Read the comment docs.

@kaxil kaxil merged commit c880221 into apache:master Jan 9, 2020
@kaxil kaxil deleted the Make-TaskInstance-logs-constants-in-Webserver-configurable branch January 9, 2020 15:11
kaxil added a commit that referenced this pull request Jan 23, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil added a commit that referenced this pull request Jan 26, 2020
kaxil added a commit that referenced this pull request Feb 3, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Feb 27, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants