Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5413] Refactor worker config #7114

Merged

Conversation

davlum
Copy link
Contributor

@davlum davlum commented Jan 9, 2020


Issue link: AIRFLOW-5413

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:Scheduler including HA (high availability) scheduler k8s labels Jan 9, 2020
@kaxil kaxil force-pushed the refactor/AIRFLOW-5413/refactor-worker-config branch from 302dff9 to 6ea232a Compare January 9, 2020 17:25
@kaxil
Copy link
Member

kaxil commented Jan 9, 2020

I have rebased and force-pushed your branch.

@davlum davlum force-pushed the refactor/AIRFLOW-5413/refactor-worker-config branch 2 times, most recently from 3815d2a to 622da42 Compare January 9, 2020 18:48
@codecov-io
Copy link

Codecov Report

Merging #7114 into master will increase coverage by 0.01%.
The diff coverage is 97.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7114      +/-   ##
==========================================
+ Coverage   85.23%   85.24%   +0.01%     
==========================================
  Files         682      682              
  Lines       39045    39092      +47     
==========================================
+ Hits        33280    33324      +44     
- Misses       5765     5768       +3
Impacted Files Coverage Δ
airflow/kubernetes/worker_configuration.py 99.29% <100%> (-0.01%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 98.78% <100%> (+0.03%) ⬆️
airflow/executors/kubernetes_executor.py 57.66% <100%> (+0.09%) ⬆️
airflow/kubernetes/pod_generator.py 95.95% <97.46%> (+0.64%) ⬆️
airflow/serialization/serialized_objects.py 90.03% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c880221...622da42. Read the comment docs.

@davlum davlum force-pushed the refactor/AIRFLOW-5413/refactor-worker-config branch from 622da42 to 0767d5e Compare January 9, 2020 19:42
@dimberman dimberman merged commit 51f262c into apache:master Jan 9, 2020
@davlum davlum deleted the refactor/AIRFLOW-5413/refactor-worker-config branch January 9, 2020 20:39
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit that referenced this pull request Jun 25, 2020
dimberman pushed a commit that referenced this pull request Jun 25, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
(cherry picked from commit 51f262c)
if not dag_id:
return None

safe_uuid = uuid.uuid4().hex

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed from the 8 character long string it was before (see old line 133) to this new 32 character long string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants