-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5167] Rolling dependencies for GCP #7116
Conversation
As a potential fix to https://issues.apache.org/jira/browse/AIRFLOW-5167 this commit changes outdated hard-pinned dependencies to rolling dependencies. While both pinned and rolling have their pros and cons, in this situation, it might be best to just deal with the bugs from rolling breaking changes as they pop up. Alternately, we should re-pin from time to time with totally hard-pinned deps. What we currently have here is a mix, so it should change one way or the other. https://issues.apache.org/jira/browse/AIRFLOW-5167
Congratulations on your first Pull Request and welcome to the Apache Airflow community! Here are some useful points:
Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: |
Codecov Report
@@ Coverage Diff @@
## master #7116 +/- ##
==========================================
- Coverage 85.23% 84.96% -0.27%
==========================================
Files 682 683 +1
Lines 39045 39155 +110
==========================================
- Hits 33280 33269 -11
- Misses 5765 5886 +121
Continue to review full report at Codecov.
|
Awesome work, congrats on your first merged pull request! |
Thanks for the quick review and merge! |
No problem. Thanks for the PR |
cherry-picked from 415d419
As a potential fix to https://issues.apache.org/jira/browse/AIRFLOW-5167 this commit changes outdated hard-pinned dependencies to rolling dependencies.
While both pinned and rolling have their pros and cons, in this situation, it might be best to just deal with the bugs from rolling breaking changes as they pop up.
Alternately, we should re-pin from time to time with totally hard-pinned deps. What we currently have here is a mix, so it should change one way or the other.
Issue link: AIRFLOW-5167
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.