Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5167] Rolling dependencies for GCP #7116

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Conversation

rayrrr
Copy link
Contributor

@rayrrr rayrrr commented Jan 9, 2020

As a potential fix to https://issues.apache.org/jira/browse/AIRFLOW-5167 this commit changes outdated hard-pinned dependencies to rolling dependencies.

While both pinned and rolling have their pros and cons, in this situation, it might be best to just deal with the bugs from rolling breaking changes as they pop up.

Alternately, we should re-pin from time to time with totally hard-pinned deps. What we currently have here is a mix, so it should change one way or the other.


Issue link: AIRFLOW-5167

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

As a potential fix to https://issues.apache.org/jira/browse/AIRFLOW-5167 this commit changes outdated hard-pinned dependencies to rolling dependencies.

While both pinned and rolling have their pros and cons, in this situation, it might be best to just deal with the bugs from rolling breaking changes as they pop up.

Alternately, we should re-pin from time to time with totally hard-pinned deps. What we currently have here is a mix, so it should change one way or the other.

https://issues.apache.org/jira/browse/AIRFLOW-5167
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 9, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits
    will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory).
    Adding a new operator? Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing
    locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from
    Committers.

Apache Airflow is a community-driven project and together we are making it better 🚀.

In case of doubts contact the developers at:
Mailing List: [email protected]
Slack: https://apache-airflow-slack.herokuapp.com/

setup.py Outdated Show resolved Hide resolved
@kaxil kaxil requested a review from potiuk January 10, 2020 14:10
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #7116 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7116      +/-   ##
==========================================
- Coverage   85.23%   84.96%   -0.27%     
==========================================
  Files         682      683       +1     
  Lines       39045    39155     +110     
==========================================
- Hits        33280    33269      -11     
- Misses       5765     5886     +121
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.04% <0%> (-20.71%) ⬇️
airflow/serialization/serialized_objects.py 90.03% <0%> (-0.69%) ⬇️
airflow/sensors/external_task_sensor.py 85.52% <0%> (-0.44%) ⬇️
airflow/www/views.py 76.07% <0%> (-0.13%) ⬇️
airflow/models/dag.py 90.86% <0%> (-0.03%) ⬇️
airflow/kubernetes/worker_configuration.py 99.29% <0%> (-0.01%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c880221...92e7e25. Read the comment docs.

@kaxil kaxil merged commit 415d419 into apache:master Jan 10, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 10, 2020

Awesome work, congrats on your first merged pull request!

@rayrrr
Copy link
Contributor Author

rayrrr commented Jan 10, 2020

Thanks for the quick review and merge!

@kaxil
Copy link
Member

kaxil commented Jan 10, 2020

Thanks for the quick review and merge!

No problem. Thanks for the PR

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit that referenced this pull request Mar 17, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants