[AIRFLOW-6506] do_xcom_push defaulting to True #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimberman
force-pushed
the
AIRFLOW-6506_do_xcom_push_fix
branch
from
e8fa532
to
f3385cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #7122 +/- ##
==========================================
- Coverage 85.24% 84.96% -0.28%
==========================================
Files 683 683
Lines 39152 39153 +1
==========================================
- Hits 33375 33267 -108
- Misses 5777 5886 +109
Continue to review full report at Codecov.
|
potiuk
approved these changes
Jan 10, 2020
kaxil
approved these changes
Jan 10, 2020
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 11, 2020
…erator (apache#7122) (cherry-picked from 86f525f) (cherry picked from commit 9659398)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6506
As of airflow 1.10.7,
do_xcom_pushdefaults to true on the BaseOperator. The KubePodOperator was not setting thedo_xcom_pushvariables so it was stuck as True.[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.