Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6528] disable flake8 W503 line break before binary operator #7124

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Jan 10, 2020

Flake8's W503 rule says there should be no line break before binary operator.

This rule is incompatible with black formatter, and is also in my opinion less readable.

Status quo example with W503 check enabled:

    @property
    def sqlalchemy_scheme(self):
        return (
            self._sqlalchemy_scheme or
            self.connection_extra_lower.get('sqlalchemy_scheme') or
            self.DEFAULT_SQLALCHEMY_SCHEME
        )

as required by black (W503 disabled)

    @property
    def sqlalchemy_scheme(self):
        return (
            self._sqlalchemy_scheme
            or self.connection_extra_lower.get('sqlalchemy_scheme')
            or self.DEFAULT_SQLALCHEMY_SCHEME
        )

Issue link: AIRFLOW-6528

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member

potiuk commented Jan 10, 2020

@mik-laj - what do you think - I am ok with it :)

@potiuk potiuk merged commit d6170e8 into apache:master Jan 10, 2020
@potiuk
Copy link
Member

potiuk commented Jan 10, 2020

Thanks @dstandish !

potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 22, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants