-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6529] Pickle error occurs when the scheduler tries to run on macOS. #7128
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
11fd854
Pull processor_factory out of _execute and move to the class scope.
sarutak f6ab7fc
Fix style
sarutak 0722530
Fix test_dag_processing.py: to comply with the change
sarutak 91d783d
Further fix style
sarutak c142623
Change the value of pickle_dags from True to False which is the defau…
sarutak 0cee214
Fix test cases in test_dag_processing.py to comply with this change.
sarutak 5dcaed4
Fix how to reference FakeDagFileProcessorRunner class due to the plac…
sarutak 8107757
Fix configuration inheritance issue using multiprocessing with spawn…
sarutak 0f8aad8
Fix style
sarutak 4cd1f61
Fix flake8 style issue
sarutak 9344c94
Fix bugs.
sarutak f5f1b5a
Fix picklable issue using multiprocessing with non-fork mode for Linux.
sarutak 689f025
Add a new CI entry for spawn-multiprocessing method.
sarutak 6d7e6a2
Resolve conflicts
sarutak 5f12283
Add testcases for multiprocessing with spawn mode.
sarutak ea5853f
Merge branch 'master' of https://github.com/apache/airflow into resol…
sarutak 396c41b
Merge branch 'master' of https://github.com/apache/airflow into resol…
sarutak 368607b
Revert code for environment-inheritance issue with spawn-multiprocess…
sarutak b612321
Fix style
sarutak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this block of code is identical to https://github.com/apache/airflow/pull/7128/files#diff-c35269bcfbbe386e269ffa7487e86192R171-R184. Given that they would probably need to change at the same time if either ever changed, this might be a good case for a utility mixin. Lines 343-352 could go into a MultiProcessingConfigMixin class or similar.