Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6451] self._print_stat() in dag_processing.py should be skippable #7134

Merged
merged 5 commits into from
Jan 28, 2020

Conversation

tooptoop4
Copy link
Contributor

@tooptoop4 tooptoop4 commented Jan 10, 2020


Issue link: AIRFLOW-6451

  • [X ] Description above provides context of the change
  • [ X] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • [ X] Unit tests coverage for changes (not needed for documentation changes)
  • [X ] Commits follow "How to write a good git commit message"
  • [ X] Relevant documentation is updated including usage instructions.
  • [ X] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@tooptoop4
Copy link
Contributor Author

@ashb

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #7134 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7134      +/-   ##
==========================================
- Coverage   85.17%   84.96%   -0.22%     
==========================================
  Files         683      683              
  Lines       39155    39152       -3     
==========================================
- Hits        33352    33264      -88     
- Misses       5803     5888      +85
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 87.93% <100%> (-0.07%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.31% <0%> (-20.49%) ⬇️
airflow/hooks/postgres_hook.py 94.36% <0%> (+1.4%) ⬆️
airflow/hooks/dbapi_hook.py 91.73% <0%> (+1.65%) ⬆️
airflow/utils/sqlalchemy.py 96.66% <0%> (+1.66%) ⬆️
airflow/operators/postgres_operator.py 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d8ef1...ad9ecc5. Read the comment docs.

@tooptoop4 tooptoop4 requested a review from potiuk January 17, 2020 21:04
@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Jan 20, 2020

@mik-laj pls merge

@mik-laj mik-laj merged commit 1d73fb3 into apache:master Jan 28, 2020
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants