[AIRFLOW-XXXX] Move UPDATING changes into correct versions #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madison-ookla
changed the title
madison-ookla
force-pushed
the
docs/UPDATING-fix
branch
from
388ee94
to
7d04742
Compare
kaxil
reviewed
Jan 15, 2020
UPDATING.md
Outdated
|
|
||
| For example: `from airflow.operators.sensors import BaseSensorOperator` | ||
| becomes `from airflow.sensors.base_sensor_operator import BaseSensorOperator` | ||
|
|
There was a problem hiding this comment.
This is still working on 1.10.7 too, so it was rightly placed in Master.
This deprecation would be for 2.0
There was a problem hiding this comment.
For reference, check: https://github.com/apache/airflow/blob/1.10.7/airflow/operators/__init__.py
There was a problem hiding this comment.
Got it, thanks! This is the one I had the most trouble finding. I'll move it back to Master
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
UPDATING.md
Outdated
Comment on lines
853
to
870
| ### Renamed "extra" requirements for cloud providers | ||
|
|
||
| Subpackages for specific services have been combined into one variant for | ||
| each cloud provider. The name of the subpackage for the Google Cloud Platform | ||
| has changed to follow style. | ||
|
|
||
| If you want to install integration for Microsoft Azure, then instead of | ||
| ``` | ||
| pip install 'apache-airflow[azure_blob_storage,azure_data_lake,azure_cosmos,azure_container_instances]' | ||
| ``` | ||
| you should execute `pip install 'apache-airflow[azure]'` | ||
|
|
||
| If you want to install integration for Amazon Web Services, then instead of | ||
| `pip install 'apache-airflow[s3,emr]'`, you should execute `pip install 'apache-airflow[aws]'` | ||
|
|
||
| If you want to install integration for Google Cloud Platform, then instead of | ||
| `pip install 'apache-airflow[gcp_api]'`, you should execute `pip install 'apache-airflow[gcp]'`. | ||
| The old way will work until the release of Airflow 2.1. |
There was a problem hiding this comment.
This is for Master. Not correct for 1.10.7
There was a problem hiding this comment.
It appears to be true in 1.10.7 for aws: https://github.com/apache/airflow/blob/1.10.7/setup.py#L154, and for gcp: https://github.com/apache/airflow/blob/1.10.7/setup.py#L220
kaxil
reviewed
Jan 15, 2020
kaxil
approved these changes
Jan 15, 2020
kaxil
added a commit
that referenced
this pull request
Jan 15, 2020
(cherry-picked from 5d87491) and adapted to 1.10.* test branch
potiuk
pushed a commit
that referenced
this pull request
Jan 21, 2020
(cherry-picked from 5d87491) and adapted to 1.10.* test branch
kaxil
added a commit
that referenced
this pull request
Jan 23, 2020
(cherry-picked from 5d87491) and adapted to 1.10.* test branch
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some documentation within the UPDATING.md file to be tied to the appropriate versions for said changes. When we were migrating to 1.10.7 from 1.10.6 we were confused by which changes had been shipped with the most recent version. I went through all of the changes under
Airflow Masterin the file and tied the issues back to the changelog found here: https://airflow.apache.org/docs/stable/changelog.html. Those that were not present in the changelog under a specific version were left inAirflow Master, but those that were present in a version were relocated to that version.Issue link:
Document only change, no JIRA issueMake sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.