[AIRFLOW-6564] Additional diagnostics information on CI check failure #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
AIRFLOW-6564-additional-diagnostics-information-on-ci-check-failure
branch
from
886b91e
to
87a0197
Compare
potiuk
force-pushed
the
AIRFLOW-6564-additional-diagnostics-information-on-ci-check-failure
branch
from
2cd1c72
to
31762e5
Compare
boring-cyborg
bot
added
the
area:Scheduler
|
For now I have not yet tried to improve entropy retrieval from Docker (I will see if that can be achieved easily) but for now I added a bit more sophisticated way of making sure the environment for tests is sane. I test each db/integration in a loop n-times + I added the special case for MySQL with parsing the logs + we have full diagnostics in case any of the checks fails. Pls. take a look! |
|
I also updated mysql to 5.7 - I might remove that and make a separate PR. |
Fokko
reviewed
Jan 15, 2020
mik-laj
reviewed
Jan 15, 2020
potiuk
force-pushed
the
AIRFLOW-6564-additional-diagnostics-information-on-ci-check-failure
branch
2 times, most recently
from
0ca023d
to
ead4811
Compare
Codecov Report
@@ Coverage Diff @@
## master #7172 +/- ##
==========================================
+ Coverage 85.24% 85.37% +0.13%
==========================================
Files 710 723 +13
Lines 39485 39543 +58
==========================================
+ Hits 33660 33761 +101
+ Misses 5825 5782 -43
Continue to review full report at Codecov.
|
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
kaxil
reviewed
Jan 15, 2020
potiuk
force-pushed
the
AIRFLOW-6564-additional-diagnostics-information-on-ci-check-failure
branch
from
ead4811
to
5f23840
Compare
potiuk
added a commit
that referenced
this pull request
Jan 25, 2020
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
…apache#7172) (cherry picked from commit 417feda) (cherry picked from commit c71f6ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6564
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.