Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6575] Entropy source for CI tests is changed to unblocking #7185

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 15, 2020

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.


Issue link: AIRFLOW-6575

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.
@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2020

Let's see when Travis completes, but I believe this change will speed up the startup - I changed the entropy source to be unblocking one and it should make the startup faster.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an acceptable long-term fix to me too.

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #7185 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7185      +/-   ##
==========================================
+ Coverage   85.25%   85.37%   +0.12%     
==========================================
  Files         723      723              
  Lines       39543    39543              
==========================================
+ Hits        33711    33761      +50     
+ Misses       5832     5782      -50
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 89.34% <0%> (+0.43%) ⬆️
airflow/hooks/dbapi_hook.py 91.73% <0%> (+1.65%) ⬆️
airflow/hooks/postgres_hook.py 94.36% <0%> (+16.9%) ⬆️
airflow/operators/postgres_to_gcs.py 85.29% <0%> (+32.35%) ⬆️
airflow/operators/postgres_operator.py 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417feda...b7568be. Read the comment docs.

@potiuk potiuk merged commit f39f26e into apache:master Jan 16, 2020
potiuk added a commit that referenced this pull request Jan 21, 2020
…7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
kaxil pushed a commit that referenced this pull request Jan 22, 2020
…7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
kaxil pushed a commit that referenced this pull request Jan 23, 2020
…7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
potiuk added a commit that referenced this pull request Jan 26, 2020
…7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
kaxil pushed a commit that referenced this pull request Jan 26, 2020
…7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…pache#7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
…pache#7185)

On Travis CI blocking entropy source slows startup time of a number of
containers. This change changes the entropy source to unblocking one.

(cherry picked from commit f39f26e)
(cherry picked from commit 310cb42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants