[AIRFLOW-6576] fix scheduler crash caused by deleted task with sla misses #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
Codecov Report
@@ Coverage Diff @@
## master #7187 +/- ##
==========================================
+ Coverage 84.91% 85.09% +0.18%
==========================================
Files 723 723
Lines 39546 39555 +9
==========================================
+ Hits 33581 33660 +79
+ Misses 5965 5895 -70
Continue to review full report at Codecov.
|
potiuk
reviewed
Jan 16, 2020
potiuk
reviewed
Jan 16, 2020
…sses When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
|
@potiuk added logging, ready for review again. |
kaxil
approved these changes
Jan 19, 2020
kaxil
pushed a commit
that referenced
this pull request
Jan 23, 2020
…sses (#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
potiuk
pushed a commit
that referenced
this pull request
Jan 26, 2020
…sses (#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
kaxil
pushed a commit
that referenced
this pull request
Jan 26, 2020
…sses (#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
kaxil
pushed a commit
that referenced
this pull request
Feb 3, 2020
…sses (#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 27, 2020
…sses (apache#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException (cherry picked from commit aa197ea)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…sses (apache#7187) When a task with SLA is deleted from a DAG after the SLA miss is logged but before the notification was sent, scheduler will crash with an AirflowException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6576
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.